Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add A3C #1755

Open
1 task done
tushdon2 opened this issue Dec 20, 2023 · 11 comments
Open
1 task done

[Feature Request] Add A3C #1755

tushdon2 opened this issue Dec 20, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@tushdon2
Copy link

tushdon2 commented Dec 20, 2023

Motivation

Add A3C implementation as presented here so that the experiments of Rainbow can be added to the examples in further contributions.

Solution

Add A3C code like A2C and add its paper reproduction as an example.

Checklist

  • I have checked that there is no similar issue in the repo (required)
@tushdon2 tushdon2 added the enhancement New feature or request label Dec 20, 2023
@tushdon2
Copy link
Author

I am interested in working on this issue along with @shivank21.

@vmoens
Copy link
Contributor

vmoens commented Dec 20, 2023

That would be wonderful!

@shivank21
Copy link

In A3C algorithm we are required to asynchronize the variables across multiple CPU threads. For that we were planning to use the threading library of python. Does that work here?
Also it refers in the Documentation that "This module used to be optional, it is now always available."
What does this really mean?

@vmoens
Copy link
Contributor

vmoens commented Jan 9, 2024

Yes threading is built-in, so that should be ok!

@albertbou92
Copy link
Contributor

Having A3C would be very cool!

@PaulBeuran
Copy link

Is this issue still open ? I'd like to contribute

@tushdon2
Copy link
Author

Yes.
I am currently working on it.
If you wish we can collaborate.

@PaulBeuran
Copy link

That would be great thanks. Do you have an open branch I can start looking ?

@tushdon2
Copy link
Author

Nope.
I was going through the background, understanding theory and how the repo works.
We can connect to discuss if you want.

@PaulBeuran
Copy link

No problem, doing the same right now.
DM me on Discord @pbeuran_71003

@tushdon2
Copy link
Author

Sent you a request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants