Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caffe2 removal #128959

Open
r-barnes opened this issue Jun 18, 2024 · 2 comments
Open

caffe2 removal #128959

r-barnes opened this issue Jun 18, 2024 · 2 comments
Labels
better-engineering Relatively self-contained tasks for better engineering contributors enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@r-barnes
Copy link
Contributor

r-barnes commented Jun 18, 2024 •
edited by pytorch-bot bot
Loading

Removing caffe2

cc @malfet @seemethere
@r-barnes
Copy link
Contributor Author

@cyyever - I was just wondering what your plans are regarding the remaining files in the caffe2/ subdirectory?

I'm hoping to see these all eliminated/refactored into other parts of the project - what do you inspired to do with the remaining stuff?

@cyyever
Copy link
Collaborator

cyyever commented Jun 18, 2024 •
edited
Loading

@r-barnes I will move the remaining modules into c10 or torch/csrc/, depending on the features they provide. For example, caffe2/core should reside in c10 and caffe2/serialize/ should be merged with torch/csrc//api/src/serialize.
Another problem is that there are several thread pool implementations: the third-party one, the c10 one and the caffe2 one. We have to find a way to unify them.

That being said, let's focus on removing outdated tests/code at the present.

@malfet malfet added module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module enhancement Not as big of a feature, but technically not a bug. Should be easy to fix better-engineering Relatively self-contained tasks for better engineering contributors labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@malfet @r-barnes @cyyever