Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[user empathy day 2][based] torch.compile issues #128071

Open
anijain2305 opened this issue Jun 5, 2024 · 0 comments
Open

[user empathy day 2][based] torch.compile issues #128071

anijain2305 opened this issue Jun 5, 2024 · 0 comments
Labels
dynamo-triage-june2024 dynamo-user-empathy-day empathy-day Label for issues from user empathy days module: dynamo module: startup-tracing-compile Compilation mechanism or time spent in (re)compilation, tracing, startup oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@anijain2305
Copy link
Contributor

anijain2305 commented Jun 5, 2024

🐛 Describe the bug

Pytorch-eager

Time = 2.8532286300323904 seconds for 10 iterations

Torch.compile backend=eager

Observations

  • One frame is getting recompiled and almost never ends. Question - why is Dynamo not giving up on that frame?
    torch/_dynamo/symbolic_convert.py:774] [49/974]
  • Perf is way too bad, mostly due to recompilation

Time = 35.62640808802098 seconds for 10 iterations
Verdict - Does not work

Other fixes

/home/anijain/local/miniconda3/envs/user_empathy_day2/lib/python3.10/site-packages/torch/_dynamo/variables/functions.py:661: UserWarning: Graph break due to unsupported builtin flash_attn_2_cuda.PyCapsule.fwd_kvcache. This function is either a Python builtin (e.g. _warnings.warn) or a third-party C/C++ Python extension (perhaps created with pybind). If it is a Python builtin, please file an issue on GitHub so the PyTorch team can add support for it and see the next case for a workaround. If it is a third-party C/C++ Python extension, please either wrap it into a PyTorch-understood custom operator (see https://pytorch.org/docs/main/notes/custom_operators.html for more details) or, if it is traceable, use torch.compiler.allow_in_graph.
warnings.warn(msg)

torch.compile with backend=aot_eager

Error logs

No response

Minified repro

No response

Versions

NA

cc @ezyang @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @oulgen @jamesjwu @aorenste @laithsakka @bdhirsh @msaroufim

@soulitzer soulitzer added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: dynamo labels Jun 10, 2024
@oulgen oulgen added module: startup-tracing-compile Compilation mechanism or time spent in (re)compilation, tracing, startup and removed compile-time labels Jun 24, 2024
@bdhirsh bdhirsh added the empathy-day Label for issues from user empathy days label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamo-triage-june2024 dynamo-user-empathy-day empathy-day Label for issues from user empathy days module: dynamo module: startup-tracing-compile Compilation mechanism or time spent in (re)compilation, tracing, startup oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants