Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address TODO: model is somehow not being freed when z3 is available #127444

Closed
laithsakka opened this issue May 29, 2024 · 4 comments
Closed

address TODO: model is somehow not being freed when z3 is available #127444

laithsakka opened this issue May 29, 2024 · 4 comments
Labels
module: dynamic shapes module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@laithsakka
Copy link
Contributor

laithsakka commented May 29, 2024

TODO model is somehow not being freed when z3 is available

repo:

  1. remove
    if not config.inline_inbuilt_nn_modules:
    # TODO model is somehow not being freed when z3 is available
    unittest.expectedFailure(
    DynamicShapesMiscTests.test_parameter_free_dynamic_shapes # noqa: F821
    )

  2. run
    python test/dynamo/test_dynamic_shapes.py -k test_parameter_free_dynamic_shapes

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng

@ezyang
Copy link
Contributor

ezyang commented May 30, 2024

iirc, the z3 code holds onto some tensors as part of the metadata it has, and that could cause this sort of problem. I'd just manually disable TV on this test.

@laithsakka
Copy link
Contributor Author

@ezyang shall i close the issue?

@ezyang
Copy link
Contributor

ezyang commented Jun 1, 2024

oh I see, we did disable it. Well, idk, if someone wants to investigate I guess they can

@zou3519 zou3519 added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: dynamo labels Jun 3, 2024
@anijain2305
Copy link
Contributor

This could be because with inlining Dynamo does not need need any pointers to the inbuilt modules. Closing because this is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: dynamic shapes module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants