Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FakeTensor support of pin_memory #123252

Open
IvanKobzarev opened this issue Apr 3, 2024 · 0 comments
Open

FakeTensor support of pin_memory #123252

IvanKobzarev opened this issue Apr 3, 2024 · 0 comments
Labels
module: dynamo module: fakeTensor module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@IvanKobzarev
Copy link
Contributor

IvanKobzarev commented Apr 3, 2024 •
edited by pytorch-bot bot
Loading

🚀 The feature, motivation and pitch

FakeTensor does not support pin_memory and dynamo can not trace through it.
For parity we need ability to add pin_memory to dynamo graph.
FakeTensor should track the state of pin-nedness of memory internally.

Alternatives

No response

Additional context

No response

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @eellison @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @zou3519
@shunting314 shunting314 added triage review triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 4, 2024
@zou3519 zou3519 added module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, module: dynamo labels Apr 9, 2024
@anijain2305 anijain2305 removed their assignment Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: dynamo module: fakeTensor module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zou3519 @IvanKobzarev @anijain2305 @bdhirsh @shunting314