Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo] Implement enumerate fallback as polyfill #112794

Open
jon-chuang opened this issue Nov 2, 2023 · 0 comments
Open

[dynamo] Implement enumerate fallback as polyfill #112794

jon-chuang opened this issue Nov 2, 2023 · 0 comments
Labels
dynamo-polyfill dynamo-triage-june2024 enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@jon-chuang
Copy link
Collaborator

jon-chuang commented Nov 2, 2023 •
edited by pytorch-bot bot
Loading

馃殌 The feature, motivation and pitch

We can do so successfully for GenericVariableIterator as defined in #112776

This cannot be guaranted to work for the infinite generators (they may not return) so we will not do it.

cc @ezyang @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @msaroufim @wconstab @bdhirsh @zou3519 @aakhundov
@davidberard98 davidberard98 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 6, 2023
@anijain2305 anijain2305 added the enhancement Not as big of a feature, but technically not a bug. Should be easy to fix label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dynamo-polyfill dynamo-triage-june2024 enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidberard98 @jon-chuang @anijain2305 @jbschlosser