Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamo] Add asserts to prevent user defined objects/classes from going into ConstantVariable #110871

Open
ezyang opened this issue Oct 9, 2023 · 0 comments
Labels
dynamo-triage-june2024 dynamo-variable-tracker module: dynamo triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ezyang
Copy link
Contributor

ezyang commented Oct 9, 2023

馃悰 Describe the bug

This is the root cause of #110794 but it's a bit hard to educate everyone not to put random crap in ConstantVariable, so it would be good if we have more asserts that help people figure out.

Primary barrier to adding the assert is we'll probably have to fix a pile of latent bugs while we're at it.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @Xia-Weiwen @aakhundov @Fidget-Spinner

Versions

main

@ezyang ezyang changed the title Add asserts to prevent user defined objects/classes from going into ClassVariable [dynamo] Add asserts to prevent user defined objects/classes from going into ConstantVariable Oct 9, 2023
@mikaylagawarecki mikaylagawarecki added module: dynamo triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamo-triage-june2024 dynamo-variable-tracker module: dynamo triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants