Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve manhattan distance tests #1791

Merged
merged 1 commit into from
Mar 14, 2021
Merged

improve manhattan distance tests #1791

merged 1 commit into from
Mar 14, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Improving ManhattanDistance tests as we did with CanberraMetric

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

sdesrozis
sdesrozis approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KickItLikeShika Thanks you ! LGTM

@KickItLikeShika
Copy link
Contributor Author

KickItLikeShika commented Mar 14, 2021 •
edited
Loading

@sdesrozis, Thanks! Please review this #1781

@sdesrozis sdesrozis merged commit 264797e into pytorch:master Mar 14, 2021
@KickItLikeShika KickItLikeShika deleted the improve-manhattan-distance-tests branch March 14, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KickItLikeShika @sdesrozis