Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNIST download patch #1738

Merged
merged 4 commits into from
Mar 4, 2021
Merged

MNIST download patch #1738

merged 4 commits into from
Mar 4, 2021

Conversation

trsvchn
Copy link
Collaborator

@trsvchn trsvchn commented Mar 4, 2021

Fixes #1737

Description:

python base patch for MNIST download issue

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 4, 2021

@vfdev-5 I am not sure about circle ci part and wget dependency for it

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 4, 2021

@vfdev-5 I am not sure about circle ci part and wget dependency for it

I think we have to install it for it and maybe GA as well

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 4, 2021

I'll check for GA

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 4, 2021

wget is fine for GA, at least for ubuntu-latest
Screenshot from 2021-03-04 14-51-30

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 4, 2021

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 4, 2021

Ok, well, our patch is not fully crossplatform, going to try smth different

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 4, 2021

Maybe, we can try to install it with

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 4, 2021

Trying chocolatey-action

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit updates.
Thanks for the patch @trsvchn !

.github/workflows/unit-tests.yml Show resolved Hide resolved
.github/workflows/unit-tests.yml Show resolved Hide resolved
@vfdev-5 vfdev-5 merged commit 14bd8a4 into pytorch:master Mar 4, 2021
@vfdev-5 vfdev-5 mentioned this pull request Mar 4, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch MNIST dataset downloading to fix CI
2 participants