Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

word_language_model: Some suggested arguments for --model are not valid #83

Closed
cuevasclemente opened this issue Feb 24, 2017 · 0 comments

Comments

@cuevasclemente
Copy link
Contributor

In the word_language_model example, the suggestions for a RNN_TANH or RNN_RELU are not valid arguments. It looks like these haven't been valid members of the API since October 2016: pytorch/pytorch@b5d1329, instead the API determines the type of RNN based on the mode argument to the RNN class.

An easy fix would be to check for either RNN_TANH or RNN_RELU and then pass that as the mode for the class, or use the LSTM or GRU models directly as is done currently in the code (by accessing the classes from getattribute(nn, 'LSTM'/'GRU')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants