Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question][Background_Matting] Unused intermediate result multi_feat. #1768

Closed
BowenBao opened this issue Jul 13, 2023 · 1 comment
Closed

Comments

@BowenBao
Copy link
Contributor

Observe multi_feat is unused and not returned. Should it be removed or is it a bug in the implementation?

multi_feat=self.model_enc_multi(multi)
oth_feat=torch.cat([self.comb_back(torch.cat([img_feat,back_feat],dim=1)),self.comb_seg(torch.cat([img_feat,seg_feat],dim=1)),self.comb_multi(torch.cat([img_feat,back_feat],dim=1))],dim=1)
out_dec=self.model_res_dec(torch.cat([img_feat,oth_feat],dim=1))
out_dec_al=self.model_res_dec_al(out_dec)
al_out=self.model_al_out(out_dec_al)
out_dec_fg=self.model_res_dec_fg(out_dec)
out_dec_fg1=self.model_dec_fg1(out_dec_fg)
fg_out=self.model_fg_out(torch.cat([out_dec_fg1,img_feat1],dim=1))
return al_out, fg_out

@xuzhao9
Copy link
Contributor

xuzhao9 commented Jul 14, 2023

This issue is from the upstream model code: https://github.com/senguptaumd/Background-Matting/blob/master/networks.py#L97

We prefer to keep the same code as the upstream code, to make sure we are improving together with the PyTorch ecosystem.
That being said, we are open to fix it, if you create a PR in the upstream repo, and reference to the upstream PR in the pytorch/benchmark PR.

@xuzhao9 xuzhao9 closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants