Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added time profiling how to guide #13

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Added time profiling how to guide #13

merged 5 commits into from
Aug 31, 2021

Conversation

Priyansi
Copy link
Collaborator

@Priyansi Priyansi commented Aug 2, 2021 •
edited

Fixes #6
This how-to guide covers:

  • Custom time profiling using Timer
  • Single epoch time and total time using State
  • BasicTimeProfiler and its methods
  • HandlersTimeProfiler and its methods

@Priyansi Priyansi changed the title Added time profiling notebook Added time profiling how to guide Aug 2, 2021
@Priyansi
Copy link
Collaborator Author

@vfdev-5 @trsvchn could you please review this?

@sdesrozis
Copy link
Contributor

@Priyansi Thank you, it looks good to me 👍🏻

trsvchn
trsvchn reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Priyansi!
LGTM!
I left comment about one nit (as for me).

how-to-guides/time-profiling.ipynb Outdated Show resolved Hide resolved
@Priyansi
Copy link
Collaborator Author

Thanks for the comment @trsvchn ! I made the requested changes.

trsvchn
trsvchn approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Priyansi ! LGTM!

@vfdev-5 vfdev-5 merged commit b2e1582 into main Aug 31, 2021
@vfdev-5 vfdev-5 deleted the add-time-profiling branch August 31, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis left review comments

@trsvchn trsvchn trsvchn approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create How to do time profiling
4 participants
@Priyansi @sdesrozis @trsvchn @vfdev-5