Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all instances of save_handler=DiskSaver(...) with save_handler=path/to/dir #53

Closed
Priyansi opened this issue Oct 21, 2021 · 5 comments
Assignees
Labels
good first issue Good for newcomers PyDataGlobal2021 For the mentored PyData Global Sprint

Comments

@Priyansi
Copy link
Collaborator

Since PyTorch-Ignite v0.4.7, we have updated save_handler in Checkpoint to pass the path to checkpoint directory rather than mentioning DiskSaver(checkpoint_dir, create_dir=True). It would be nice if this could be updated for all instances in this repository too. One such instance can be in under Checkpointing in How to convert PyTorch Code to Ignite.

@Priyansi Priyansi added PyDataGlobal2021 For the mentored PyData Global Sprint good first issue Good for newcomers labels Oct 21, 2021
@anirudhb11
Copy link
Contributor

@Priyansi could you please assign this to me?

@sdesrozis
Copy link
Contributor

@anirudhb11 Thank you for your interest !

@Priyansi
Copy link
Collaborator Author

Hey @anirudhb11 , any updates on this?

@anirudhb11
Copy link
Contributor

@Priyansi am a bit occupied with some other engagements, I will raise a PR positively by Sunday.

@Priyansi
Copy link
Collaborator Author

@anirudhb11 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers PyDataGlobal2021 For the mentored PyData Global Sprint
Projects
None yet
Development

No branches or pull requests

3 participants