-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added how-to guide: Loggers #58
Conversation
Thank you for this amazing PR @anirudhb11 . Just a few structural changes and we should be good to merge. Also, I was thinking if we could move the comments inside the code in the notebook as a text cell above that and add the comments as steps there (1, 2, 3, ...). It will render better on the website. |
Co-authored-by: Priyansi <[email protected]>
Thanks @Priyansi, have made some changes to address comments raised by you |
Hey @anirudhb11 , the code looks good now however my concern was not to remove the comments altogether rather add them in the text cell above so that we have a little more explanation rather than just code. For example - Where to initialize the ClearMLLogger, what are the other handlers like WeightScaler, WeightHist, etc that we can attach and why. You don't need to explain the part before and after (setting up trainer, checkpoint, etc). |
Co-authored-by: Priyansi <[email protected]>
Thanks for the clarification, will add a description on these lines. |
@anirudhb11 could you please update the PR and we could land it. Thanks a lot ! |
@vfdev-5 thanks for reminder, apologies for the delayed response, have added a brief explanation regarding the usage as requested by @Priyansi |
@anirudhb11 Thanks for the update! I let @Priyansi review this PR and merge if everything is ok. By the way, we are using Could you please add that as well. |
Thanks so much @anirudhb11 for adding the explanation! We should be good to merge once @vfdev-5 's comment is resolved. |
Have added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot the PR @anirudhb11
LGTM!
Resolves #44,
A how-to guide for loggers in Ignite. Demonstrates the usage with one logger (
ClearML
) and how the usage can be extended to other loggers