Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added how-to guide: convert pure pytorch code to ignite #25

Merged
merged 13 commits into from
Sep 7, 2021
Merged

Added how-to guide: convert pure pytorch code to ignite #25

merged 13 commits into from
Sep 7, 2021

Conversation

Priyansi
Copy link
Collaborator

@Priyansi Priyansi commented Aug 17, 2021 •
edited
Loading

Fixes #14

Abstract code comparing PyTorch and Ignite for:

  • Training loop
  • Validation loop
  • Metrics
  • Events and Handlers
  • Progress Bar
  • Checkpoint

To do:

  • GIF showing moving code once the notebook is finalized

@Priyansi Priyansi changed the title Added beginner tutorial: convert pure pytorch code to ignite Added how-to guide: convert pure pytorch code to ignite Aug 17, 2021
vfdev-5
vfdev-5 reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyansi nice how to guide. Few improvements to bring and it is good to go.
I remember also we wanted to make and insert here a gif.
Maybe, it would worth to add few links (something like complete code example) in the end.

@vfdev-5
Copy link
Member

vfdev-5 commented Sep 3, 2021

@Priyansi thanks for updates.

Let's add few links in the end of the text on a complete code example

vfdev-5
vfdev-5 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit fix, otherwise looks good to merge

@vfdev-5
Copy link
Member

vfdev-5 commented Sep 7, 2021

I hope GIF rendering will be neater than on GH

@Priyansi @vfdev-5
Update nb
7dca48b 
Co-authored-by: vfdev <[email protected]>
@Priyansi
Copy link
Collaborator Author

Priyansi commented Sep 7, 2021

@vfdev-5 i made the suggested change.

@vfdev-5 vfdev-5 merged commit 67214c3 into main Sep 7, 2021
@vfdev-5 vfdev-5 deleted the add-convert-to-ignite-tut branch September 7, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@sdesrozis sdesrozis Awaiting requested review from sdesrozis

@trsvchn trsvchn Awaiting requested review from trsvchn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert pure pytorch code to ignite
2 participants
@Priyansi @vfdev-5