Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several pickle files #75

Closed
wants to merge 1 commit into from
Closed

several pickle files #75

wants to merge 1 commit into from

Conversation

shaypal5
Copy link
Collaborator

No description provided.

@shaypal5 shaypal5 self-assigned this Sep 19, 2021
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@shaypal5 shaypal5 temporarily deployed to test September 19, 2021 12:05 Inactive
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #75 (863771e) into master (83fe776) will increase coverage by 1.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   95.98%   97.38%   +1.40%     
==========================================
  Files           4        4              
  Lines         324      383      +59     
  Branches       30       46      +16     
==========================================
+ Hits          311      373      +62     
+ Misses          8        5       -3     
  Partials        5        5              
Impacted Files Coverage Δ
cachier/core.py 94.54% <ø> (ø)
cachier/pickle_core.py 98.92% <100.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fe776...863771e. Read the comment docs.

@erap129
Copy link
Contributor

erap129 commented Sep 19, 2021

hmm for some reason this contribution appears under the github account @eladrap, even though I made the PR via this account (erap129). Did you somehow add @eladrap manually? If so I would be glad if you can swap it so this work will appear under this account (erap129). Thanks.

@erap129
Copy link
Contributor

erap129 commented Sep 24, 2021

Hi, are we missing anything for this to continue? Thanks :)

@erap129
Copy link
Contributor

erap129 commented Oct 4, 2021

Really hate to nag but do you think we will follow through with this? Thanks.

@shaypal5
Copy link
Collaborator Author

shaypal5 commented Oct 5, 2021

Hey, all good. Good of you to nag. :)

@shaypal5
Copy link
Collaborator Author

shaypal5 commented Oct 5, 2021

I didn't change anything manually. I wouldn't even know how to try something like altering the username this appears under.

Do you want to resubmit this under the correct username?
Maybe delete the other account?

@erap129
Copy link
Contributor

erap129 commented Oct 5, 2021

Yeah it was me of course, I made a mess by confusing my private and work accounts. I amended the commit to change the author and made the PR again. It's my first open-source contribution so I guess I'm just checking off beginner mistakes :)

@shaypal5 shaypal5 closed this Oct 6, 2021
@shaypal5
Copy link
Collaborator Author

shaypal5 commented Oct 6, 2021

:)

@shaypal5 shaypal5 deleted the multifilepickle branch October 6, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants