Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel creation #7

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Fix wheel creation #7

merged 1 commit into from
Nov 26, 2017

Conversation

mikeage
Copy link
Contributor

@mikeage mikeage commented Nov 26, 2017

Without this, attempting to build a wheel produces:

$ python setup.py bdist_wheel
/path/to/venv/lib/python2.7/site-packages/setuptools/dist.py:333: UserWarning: Normalizing '1.2.1.post.dev3' to '1.2.1.post0.dev3'
  normalized_version,
running bdist_wheel
error: invalid truth value ''

Without this, attempting to build a wheel produces:
```bash
$ python setup.py bdist_wheel
/path/to/venv/lib/python2.7/site-packages/setuptools/dist.py:333: UserWarning: Normalizing '1.2.1.post.dev3' to '1.2.1.post0.dev3'
  normalized_version,
running bdist_wheel
error: invalid truth value ''
```
@codecov
Copy link

codecov bot commented Nov 26, 2017

Codecov Report

Merging #7 into master will decrease coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   95.34%   94.68%   -0.67%     
==========================================
  Files           4        4              
  Lines         301      301              
  Branches       28       28              
==========================================
- Hits          287      285       -2     
- Misses          8        9       +1     
- Partials        6        7       +1
Impacted Files Coverage Δ
cachier/pickle_core.py 93.65% <0%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2931fe5...3355fcf. Read the comment docs.

@fruch
Copy link

fruch commented Nov 26, 2017

👍
not sure what codecov/project mean...

@shaypal5
Copy link
Collaborator

shaypal5 commented Nov 26, 2017

Hmmm. Yes, universal = 1 should have been there from the onset. I think it's a typo.

I'm also not sure what codecov/project means, and how it is different than codecov/patch, and also how can coverage go down (unless codecov didn't run for some changes I made), as pickle_core.py wasn't even changed.

Which means I'm pulling it, as it passes all tests.
I can bump coverage in a separate PR, if I deem it necessary, anyway.

Thanks, @mikeage !

@shaypal5 shaypal5 merged commit 45c8a3b into python-cachier:master Nov 26, 2017
@shaypal5
Copy link
Collaborator

shaypal5 commented Nov 26, 2017

I am, however, not pushing a new version to PyPI, as I'm only hosting source distributions there, and as far as I understand this is only relevant when building from source (i.e. pulling the repo and running python setup.py bdist_wheel in its root folder).

@mikeage
Copy link
Contributor Author

mikeage commented Nov 26, 2017

Thanks @shaypal5 !

@mikeage mikeage deleted the fix_wheel branch November 26, 2017 13:07
@mikeage
Copy link
Contributor Author

mikeage commented Nov 26, 2017

My actual use case is building a wheel from pypi for local redistribution. For now, I've pointed my requirements.txt to git, but it would be nice to be able to build a wheel from the version at pypi.

Alternatively, is there any reason you don't publish wheels along with the tarballs?

@shaypal5
Copy link
Collaborator

Hmmm. Oh, then tell me what I have to do?
Just run python setup.py sdist bdist_wheel upload instead of just python setup.py sdist upload?

@mikeage
Copy link
Contributor Author

mikeage commented Nov 26, 2017

exactly

@shaypal5
Copy link
Collaborator

Cool. Read about it a tiny bit and uploaded v1.2.2 to PyPI, including a wheel.
Can you take a look, try it out, and tell me if it's all good?

@mikeage
Copy link
Contributor Author

mikeage commented Nov 26, 2017

looks great, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants