fix addmarker - extract mark from markdecorator #3576

RonnyPfannschmidt · 2018-06-12T12:50:55Z

fixes #3501 and others

Apparently this was an old version of the docs, which has long been superseded

…utors-guide Improve contributing instructions regarding black/linting

nicoddemus · 2018-06-12T12:53:56Z

src/_pytest/nodes.py

 """ dynamically add a marker object to the node.

 ``marker`` can be a string or pytest.mark.* instance.
+ ``append=True`` whether to append the martker,


typo: marker

nicoddemus · 2018-06-12T12:54:36Z

src/_pytest/nodes.py

@@ -173,10 +173,12 @@ def listchain(self):
 chain.reverse()
 return chain

- def add_marker(self, marker):
+ def add_marker(self, marker, append=True):


Nice 👍

This will need to go to features though.

should we split the addition of append=True then?

I think so, unfortunately.

While discussing API, should we introduce a prepend_marker instead of adding a boolean flag to add_marker? I don't have a strong opinion, just thought I would mention.

its in line with stuff like python warnings, so i'd like to keep

Sure, no problem.

fixed

nicoddemus · 2018-06-12T14:06:04Z

src/_pytest/mark/structures.py

+ def validate_marks(self, attribute, value):
+ for item in value:
+ if not isinstance(item, Mark):
+ raise ValueError(item)


Please add a more descriptive message:

raise ValueError('MarkInfo expects Mark instances, got {!r} (!{r})'.format(item, type(item)))

Fix three spaces instead of four in docs

Remove unused scripts and old docs

fix addmarker - extract mark from markdecorator

nicoddemus · 2018-06-13T10:32:23Z

@RonnyPfannschmidt you plan to continue with the append parameter to add_marker in this PR or in another one?

RonnyPfannschmidt · 2018-06-13T13:54:57Z

yes, i'll rebase later

rebased and changed

nicoddemus

Thanks @RonnyPfannschmidt!

coveralls · 2018-06-13T16:01:23Z

Coverage increased (+0.04%) to 92.71% when pulling 8d07220 on RonnyPfannschmidt:addmarker-api into e0a1da4 on pytest-dev:features.

nicoddemus · 2018-06-13T20:05:02Z

Grrr...

RonnyPfannschmidt · 2018-06-13T20:11:09Z

@nicoddemus local pre-commit runb --all-files is a lifesaver ^^

nicoddemus · 2018-06-13T20:41:51Z

Definitely. 😁

Problem is that I did the fix using the web interface, it was supposed to be "trivial"... oh well!

RonnyPfannschmidt · 2018-06-13T21:03:11Z

@nicoddemus one thing my own trivial fixes have taught me is, that more than half of them raise a finger ^^

nicoddemus · 2018-06-13T21:36:36Z

Heh!

Merged, finally!

This PR updates [pytest](https://pypi.org/project/pytest) from **3.6.4** to **3.7.0**. <details> <summary>Changelog</summary> ### 3.7.0 ``` ========================= Deprecations and Removals ------------------------- - `2639 <https://github.com/pytest-dev/pytest/issues/2639>`_: ``pytest_namespace`` has been deprecated. See the documentation for ``pytest_namespace`` hook for suggestions on how to deal with this in plugins which use this functionality. - `3661 <https://github.com/pytest-dev/pytest/issues/3661>`_: Calling a fixture function directly, as opposed to request them in a test function, now issues a ``RemovedInPytest4Warning``. It will be changed into an error in pytest ``4.0``. This is a great source of confusion to new users, which will often call the fixture functions and request them from test functions interchangeably, which breaks the fixture resolution model. Features -------- - `2283 <https://github.com/pytest-dev/pytest/issues/2283>`_: New ``package`` fixture scope: fixtures are finalized when the last test of a *package* finishes. This feature is considered **experimental**, so use it sparingly. - `3576 <https://github.com/pytest-dev/pytest/issues/3576>`_: ``Node.add_marker`` now supports an ``append=True/False`` parameter to determine whether the mark comes last (default) or first. - `3579 <https://github.com/pytest-dev/pytest/issues/3579>`_: Fixture ``caplog`` now has a ``messages`` property, providing convenient access to the format-interpolated log messages without the extra data provided by the formatter/handler. - `3610 <https://github.com/pytest-dev/pytest/issues/3610>`_: New ``--trace`` option to enter the debugger at the start of a test. - `3623 <https://github.com/pytest-dev/pytest/issues/3623>`_: Introduce ``pytester.copy_example`` as helper to do acceptance tests against examples from the project. Bug Fixes --------- - `2220 <https://github.com/pytest-dev/pytest/issues/2220>`_: Fix a bug where fixtures overridden by direct parameters (for example parametrization) were being instantiated even if they were not being used by a test. - `3695 <https://github.com/pytest-dev/pytest/issues/3695>`_: Fix ``ApproxNumpy`` initialisation argument mixup, ``abs`` and ``rel`` tolerances were flipped causing strange comparsion results. Add tests to check ``abs`` and ``rel`` tolerances for ``np.array`` and test for expecting ``nan`` with ``np.array()`` - `980 <https://github.com/pytest-dev/pytest/issues/980>`_: Fix truncated locals output in verbose mode. Improved Documentation ---------------------- - `3295 <https://github.com/pytest-dev/pytest/issues/3295>`_: Correct the usage documentation of ``--last-failed-no-failures`` by adding the missing ``--last-failed`` argument in the presented examples, because they are misleading and lead to think that the missing argument is not needed. Trivial/Internal Changes ------------------------ - `3519 <https://github.com/pytest-dev/pytest/issues/3519>`_: Now a ``README.md`` file is created in ``.pytest_cache`` to make it clear why the directory exists. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Repo: https://github.com/pytest-dev/pytest/issues - Homepage: http:https://pytest.org </details>

This PR updates [pytest](https://pypi.org/project/pytest) from **3.6.2** to **3.7.1**. <details> <summary>Changelog</summary> ### 3.7.1 ``` ========================= Bug Fixes --------- - `3473 <https://github.com/pytest-dev/pytest/issues/3473>`_: Raise immediately if ``approx()`` is given an expected value of a type it doesn't understand (e.g. strings, nested dicts, etc.). - `3712 <https://github.com/pytest-dev/pytest/issues/3712>`_: Correctly represent the dimensions of an numpy array when calling ``repr()`` on ``approx()``. - `3742 <https://github.com/pytest-dev/pytest/issues/3742>`_: Fix incompatibility with third party plugins during collection, which produced the error ``object has no attribute '_collectfile'``. - `3745 <https://github.com/pytest-dev/pytest/issues/3745>`_: Display the absolute path if ``cache_dir`` is not relative to the ``rootdir`` instead of failing. - `3747 <https://github.com/pytest-dev/pytest/issues/3747>`_: Fix compatibility problem with plugins and the warning code issued by fixture functions when they are called directly. - `3748 <https://github.com/pytest-dev/pytest/issues/3748>`_: Fix infinite recursion in ``pytest.approx`` with arrays in ``numpy<1.13``. - `3757 <https://github.com/pytest-dev/pytest/issues/3757>`_: Pin pathlib2 to ``>=2.2.0`` as we require ``__fspath__`` support. - `3763 <https://github.com/pytest-dev/pytest/issues/3763>`_: Fix ``TypeError`` when the assertion message is ``bytes`` in python 3. ``` ### 3.7.0 ``` ========================= Deprecations and Removals ------------------------- - `2639 <https://github.com/pytest-dev/pytest/issues/2639>`_: ``pytest_namespace`` has been deprecated. See the documentation for ``pytest_namespace`` hook for suggestions on how to deal with this in plugins which use this functionality. - `3661 <https://github.com/pytest-dev/pytest/issues/3661>`_: Calling a fixture function directly, as opposed to request them in a test function, now issues a ``RemovedInPytest4Warning``. It will be changed into an error in pytest ``4.0``. This is a great source of confusion to new users, which will often call the fixture functions and request them from test functions interchangeably, which breaks the fixture resolution model. Features -------- - `2283 <https://github.com/pytest-dev/pytest/issues/2283>`_: New ``package`` fixture scope: fixtures are finalized when the last test of a *package* finishes. This feature is considered **experimental**, so use it sparingly. - `3576 <https://github.com/pytest-dev/pytest/issues/3576>`_: ``Node.add_marker`` now supports an ``append=True/False`` parameter to determine whether the mark comes last (default) or first. - `3579 <https://github.com/pytest-dev/pytest/issues/3579>`_: Fixture ``caplog`` now has a ``messages`` property, providing convenient access to the format-interpolated log messages without the extra data provided by the formatter/handler. - `3610 <https://github.com/pytest-dev/pytest/issues/3610>`_: New ``--trace`` option to enter the debugger at the start of a test. - `3623 <https://github.com/pytest-dev/pytest/issues/3623>`_: Introduce ``pytester.copy_example`` as helper to do acceptance tests against examples from the project. Bug Fixes --------- - `2220 <https://github.com/pytest-dev/pytest/issues/2220>`_: Fix a bug where fixtures overridden by direct parameters (for example parametrization) were being instantiated even if they were not being used by a test. - `3695 <https://github.com/pytest-dev/pytest/issues/3695>`_: Fix ``ApproxNumpy`` initialisation argument mixup, ``abs`` and ``rel`` tolerances were flipped causing strange comparsion results. Add tests to check ``abs`` and ``rel`` tolerances for ``np.array`` and test for expecting ``nan`` with ``np.array()`` - `980 <https://github.com/pytest-dev/pytest/issues/980>`_: Fix truncated locals output in verbose mode. Improved Documentation ---------------------- - `3295 <https://github.com/pytest-dev/pytest/issues/3295>`_: Correct the usage documentation of ``--last-failed-no-failures`` by adding the missing ``--last-failed`` argument in the presented examples, because they are misleading and lead to think that the missing argument is not needed. Trivial/Internal Changes ------------------------ - `3519 <https://github.com/pytest-dev/pytest/issues/3519>`_: Now a ``README.md`` file is created in ``.pytest_cache`` to make it clear why the directory exists. ``` ### 3.6.4 ``` ========================= Bug Fixes --------- - Invoke pytest using ``-mpytest`` so ``sys.path`` does not get polluted by packages installed in ``site-packages``. (`742 <https://github.com/pytest-dev/pytest/issues/742>`_) Improved Documentation ---------------------- - Use ``smtp_connection`` instead of ``smtp`` in fixtures documentation to avoid possible confusion. (`3592 <https://github.com/pytest-dev/pytest/issues/3592>`_) Trivial/Internal Changes ------------------------ - Remove obsolete ``__future__`` imports. (`2319 <https://github.com/pytest-dev/pytest/issues/2319>`_) - Add CITATION to provide information on how to formally cite pytest. (`3402 <https://github.com/pytest-dev/pytest/issues/3402>`_) - Replace broken type annotations with type comments. (`3635 <https://github.com/pytest-dev/pytest/issues/3635>`_) - Pin ``pluggy`` to ``<0.8``. (`3727 <https://github.com/pytest-dev/pytest/issues/3727>`_) ``` ### 3.6.3 ``` ========================= Bug Fixes --------- - Fix ``ImportWarning`` triggered by explicit relative imports in assertion-rewritten package modules. (`3061 <https://github.com/pytest-dev/pytest/issues/3061>`_) - Fix error in ``pytest.approx`` when dealing with 0-dimension numpy arrays. (`3593 <https://github.com/pytest-dev/pytest/issues/3593>`_) - No longer raise ``ValueError`` when using the ``get_marker`` API. (`3605 <https://github.com/pytest-dev/pytest/issues/3605>`_) - Fix problem where log messages with non-ascii characters would not appear in the output log file. (`3630 <https://github.com/pytest-dev/pytest/issues/3630>`_) - No longer raise ``AttributeError`` when legacy marks can't be stored in functions. (`3631 <https://github.com/pytest-dev/pytest/issues/3631>`_) Improved Documentation ---------------------- - The description above the example for ``pytest.mark.skipif`` now better matches the code. (`3611 <https://github.com/pytest-dev/pytest/issues/3611>`_) Trivial/Internal Changes ------------------------ - Internal refactoring: removed unused ``CallSpec2tox ._globalid_args`` attribute and ``metafunc`` parameter from ``CallSpec2.copy()``. (`3598 <https://github.com/pytest-dev/pytest/issues/3598>`_) - Silence usage of ``reduce`` warning in Python 2 (`3609 <https://github.com/pytest-dev/pytest/issues/3609>`_) - Fix usage of ``attr.ib`` deprecated ``convert`` parameter. (`3653 <https://github.com/pytest-dev/pytest/issues/3653>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Repo: https://github.com/pytest-dev/pytest/issues - Homepage: http:https://pytest.org </details>

This PR updates [pytest](https://pypi.org/project/pytest) from **3.6.4** to **3.7.2**. <details> <summary>Changelog</summary> ### 3.7.2 ``` ========================= Bug Fixes --------- - `3671 <https://github.com/pytest-dev/pytest/issues/3671>`_: Fix ``filterwarnings`` not being registered as a builtin mark. - `3768 <https://github.com/pytest-dev/pytest/issues/3768>`_, `3789 <https://github.com/pytest-dev/pytest/issues/3789>`_: Fix test collection from packages mixed with normal directories. - `3771 <https://github.com/pytest-dev/pytest/issues/3771>`_: Fix infinite recursion during collection if a ``pytest_ignore_collect`` hook returns ``False`` instead of ``None``. - `3774 <https://github.com/pytest-dev/pytest/issues/3774>`_: Fix bug where decorated fixtures would lose functionality (for example ``mock.patch``). - `3775 <https://github.com/pytest-dev/pytest/issues/3775>`_: Fix bug where importing modules or other objects with prefix ``pytest_`` prefix would raise a ``PluginValidationError``. - `3788 <https://github.com/pytest-dev/pytest/issues/3788>`_: Fix ``AttributeError`` during teardown of ``TestCase`` subclasses which raise an exception during ``__init__``. - `3804 <https://github.com/pytest-dev/pytest/issues/3804>`_: Fix traceback reporting for exceptions with ``__cause__`` cycles. Improved Documentation ---------------------- - `3746 <https://github.com/pytest-dev/pytest/issues/3746>`_: Add documentation for ``metafunc.config`` that had been mistakenly hidden. ``` ### 3.7.1 ``` ========================= Bug Fixes --------- - `3473 <https://github.com/pytest-dev/pytest/issues/3473>`_: Raise immediately if ``approx()`` is given an expected value of a type it doesn't understand (e.g. strings, nested dicts, etc.). - `3712 <https://github.com/pytest-dev/pytest/issues/3712>`_: Correctly represent the dimensions of an numpy array when calling ``repr()`` on ``approx()``. - `3742 <https://github.com/pytest-dev/pytest/issues/3742>`_: Fix incompatibility with third party plugins during collection, which produced the error ``object has no attribute '_collectfile'``. - `3745 <https://github.com/pytest-dev/pytest/issues/3745>`_: Display the absolute path if ``cache_dir`` is not relative to the ``rootdir`` instead of failing. - `3747 <https://github.com/pytest-dev/pytest/issues/3747>`_: Fix compatibility problem with plugins and the warning code issued by fixture functions when they are called directly. - `3748 <https://github.com/pytest-dev/pytest/issues/3748>`_: Fix infinite recursion in ``pytest.approx`` with arrays in ``numpy<1.13``. - `3757 <https://github.com/pytest-dev/pytest/issues/3757>`_: Pin pathlib2 to ``>=2.2.0`` as we require ``__fspath__`` support. - `3763 <https://github.com/pytest-dev/pytest/issues/3763>`_: Fix ``TypeError`` when the assertion message is ``bytes`` in python 3. ``` ### 3.7.0 ``` ========================= Deprecations and Removals ------------------------- - `2639 <https://github.com/pytest-dev/pytest/issues/2639>`_: ``pytest_namespace`` has been deprecated. See the documentation for ``pytest_namespace`` hook for suggestions on how to deal with this in plugins which use this functionality. - `3661 <https://github.com/pytest-dev/pytest/issues/3661>`_: Calling a fixture function directly, as opposed to request them in a test function, now issues a ``RemovedInPytest4Warning``. It will be changed into an error in pytest ``4.0``. This is a great source of confusion to new users, which will often call the fixture functions and request them from test functions interchangeably, which breaks the fixture resolution model. Features -------- - `2283 <https://github.com/pytest-dev/pytest/issues/2283>`_: New ``package`` fixture scope: fixtures are finalized when the last test of a *package* finishes. This feature is considered **experimental**, so use it sparingly. - `3576 <https://github.com/pytest-dev/pytest/issues/3576>`_: ``Node.add_marker`` now supports an ``append=True/False`` parameter to determine whether the mark comes last (default) or first. - `3579 <https://github.com/pytest-dev/pytest/issues/3579>`_: Fixture ``caplog`` now has a ``messages`` property, providing convenient access to the format-interpolated log messages without the extra data provided by the formatter/handler. - `3610 <https://github.com/pytest-dev/pytest/issues/3610>`_: New ``--trace`` option to enter the debugger at the start of a test. - `3623 <https://github.com/pytest-dev/pytest/issues/3623>`_: Introduce ``pytester.copy_example`` as helper to do acceptance tests against examples from the project. Bug Fixes --------- - `2220 <https://github.com/pytest-dev/pytest/issues/2220>`_: Fix a bug where fixtures overridden by direct parameters (for example parametrization) were being instantiated even if they were not being used by a test. - `3695 <https://github.com/pytest-dev/pytest/issues/3695>`_: Fix ``ApproxNumpy`` initialisation argument mixup, ``abs`` and ``rel`` tolerances were flipped causing strange comparsion results. Add tests to check ``abs`` and ``rel`` tolerances for ``np.array`` and test for expecting ``nan`` with ``np.array()`` - `980 <https://github.com/pytest-dev/pytest/issues/980>`_: Fix truncated locals output in verbose mode. Improved Documentation ---------------------- - `3295 <https://github.com/pytest-dev/pytest/issues/3295>`_: Correct the usage documentation of ``--last-failed-no-failures`` by adding the missing ``--last-failed`` argument in the presented examples, because they are misleading and lead to think that the missing argument is not needed. Trivial/Internal Changes ------------------------ - `3519 <https://github.com/pytest-dev/pytest/issues/3519>`_: Now a ``README.md`` file is created in ``.pytest_cache`` to make it clear why the directory exists. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: http:https://pytest.org </details>

nicoddemus and others added 4 commits June 11, 2018 20:49

Improve contributing instructions regarding black/linting

f300f7f

Remove unused scripts from docs

4983de6

Remove obsolete doc/en/test directory

d6e7b1a

Apparently this was an old version of the docs, which has long been superseded

Merge pull request pytest-dev#3571 from nicoddemus/pre-commit-contrib…

1b5322d

…utors-guide Improve contributing instructions regarding black/linting

RonnyPfannschmidt requested a review from nicoddemus June 12, 2018 12:51

RonnyPfannschmidt force-pushed the addmarker-api branch from a082724 to e390323 Compare June 12, 2018 12:55

nicoddemus previously requested changes Jun 12, 2018

View reviewed changes

RonnyPfannschmidt force-pushed the addmarker-api branch from e390323 to 001e435 Compare June 12, 2018 13:07

fix addmarker - extract mark from markdecorator

37793d4

nicoddemus previously requested changes Jun 12, 2018

View reviewed changes

nicoddemus and others added 8 commits June 12, 2018 11:07

Improve CHANGELOG formatting

9a7c3a6

rework Node.add_marker parameter list and docstring

b0ec442

Fix three spaces instead of four in docs

f786534

Merge pull request pytest-dev#3578 from BartoszCki/master

077c44c

Fix three spaces instead of four in docs

Merge pull request pytest-dev#3572 from nicoddemus/remove-unused-scripts

52c4279

Remove unused scripts and old docs

mark test_wrapped_getfuncargnames_patching as xfail

321f66f

Add mock dependency to py27-nobyte

88ae21f

Merge pull request pytest-dev#3577 from RonnyPfannschmidt/addmarker-fix

4d0297b

fix addmarker - extract mark from markdecorator

fix addmarker - extract mark from markdecorator

eb0c6a8

RonnyPfannschmidt force-pushed the addmarker-api branch from 001e435 to eb0c6a8 Compare June 13, 2018 15:27

changelog

791bb35

RonnyPfannschmidt changed the base branch from master to features June 13, 2018 15:30

nicoddemus approved these changes Jun 13, 2018

View reviewed changes

nicoddemus and others added 2 commits June 13, 2018 14:57

Fix add_marker docs

b5102d0

fix whitespace

8d07220

nicoddemus merged commit 94c41be into pytest-dev:features Jun 13, 2018

RonnyPfannschmidt deleted the addmarker-api branch August 2, 2018 10:32

RonnyPfannschmidt mentioned this pull request Dec 21, 2018

Override marks on items? #3501

Closed

ArchangeGabriel mentioned this pull request Jan 16, 2019

Backport PRs #12154, #12294, #12297, #12316, #13159 & #13205 to fix multiple tests issues matplotlib/matplotlib#13181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix addmarker - extract mark from markdecorator #3576

fix addmarker - extract mark from markdecorator #3576

RonnyPfannschmidt commented Jun 12, 2018

nicoddemus Jun 12, 2018

nicoddemus Jun 12, 2018

RonnyPfannschmidt Jun 12, 2018

nicoddemus Jun 12, 2018

nicoddemus Jun 12, 2018 •

edited

Loading

RonnyPfannschmidt Jun 12, 2018

nicoddemus Jun 12, 2018

nicoddemus Jun 12, 2018

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus left a comment

coveralls commented Jun 13, 2018 •

edited

Loading

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus commented Jun 13, 2018

fix addmarker - extract mark from markdecorator #3576

fix addmarker - extract mark from markdecorator #3576

Conversation

RonnyPfannschmidt commented Jun 12, 2018

nicoddemus Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus Jun 12, 2018

Choose a reason for hiding this comment

RonnyPfannschmidt Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus Jun 12, 2018 • edited Loading

Choose a reason for hiding this comment

RonnyPfannschmidt Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus Jun 12, 2018

Choose a reason for hiding this comment

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus left a comment

Choose a reason for hiding this comment

coveralls commented Jun 13, 2018 • edited Loading

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus commented Jun 13, 2018

RonnyPfannschmidt commented Jun 13, 2018

nicoddemus commented Jun 13, 2018

nicoddemus Jun 12, 2018 •

edited

Loading

coveralls commented Jun 13, 2018 •

edited

Loading