Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix release PRs do not trigger test suite on CI #12832

Open
1 task done
pradyunsg opened this issue Jul 7, 2024 · 1 comment
Open
1 task done

Bugfix release PRs do not trigger test suite on CI #12832

pradyunsg opened this issue Jul 7, 2024 · 1 comment
Labels
type: bug A confirmed bug or unintended behavior type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

Description

#12831 did not run the test suite.

Expected behavior

The tests are run for a release PR, even if it is a bugfix release.

pip version

24.1.2

Python version

N/A

OS

N/A

How to Reproduce

File a bugfix PR, based on the procedure documented at https://pip.pypa.io/en/stable/development/release-process/#creating-a-bug-fix-release

Output

See PR linked above.

Code of Conduct

@pradyunsg pradyunsg added type: bug A confirmed bug or unintended behavior S: needs triage Issues/PRs that need to be triaged type: maintenance Related to Development and Maintenance Processes and removed S: needs triage Issues/PRs that need to be triaged labels Jul 7, 2024
@ichard26
Copy link
Member

ichard26 commented Jul 8, 2024

The problem is that bugfix release PRs do not result in a modification of any of the files that would trigger a test suite run.

tests:
# Anything that's touching code-related stuff
- ".github/workflows/ci.yml"
- "src/**"
- "tests/**"
- "noxfile.py"

For 24.1, the PR does bump the version number which was then detected by the determine-changes job.

For 24.1.2 (and 24.1.1), while the version number is bumped temporarily, it's reverted to the original version on main in the same PR, resulting in no net change in src/pip/_internal/__init__.py.

To work around this, perhaps it would be best to also trigger a test suite run when NEWS.rst is modified or when files are deleted from news/ (either of which typically only happens when cutting a new release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug or unintended behavior type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

2 participants