-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImportError on S3DirEntry from 'mirror' operation #1683
Comments
Interesting, we don't support / test Python 3.9 to start with. We may have used more recent python syntax. I would have expected you would have had to hack things to get it to install in 3.9? If not, that's a bug too. That aside, I would have expected our CI to catch this on the PR that updated to 0.5.0. Happy to revert for now.
I even more welcome a PR to upgrade to latest APIs + plugging the missing testing. I started locally on #1672 but just haven't had the time to finish it and test it ... all help welcome. |
I didn't have any trouble installing on 3.9, funnily enough. I was able to get my environment to work by pinning the I haven't got the cycles to contribute today, unfortunately, but I'm back up and working with just that install tweak. |
Hello, I'm using a fresh install of
bandersnatch[s3]
in attempt to establish a private S3-backed mirror. I discovered this issue in Python 3.9, but was able to reproduce it on Python 3.11. Here is an example configuration, and the following stack trace.It appears the commit in the upstream
s3path
package is liormizr/s3path@5ea0bd2. It looks like this change first appeared in version0.5.0
, and that the latest tag without it is0.4.2
.A proper fix should probably update the Bandersnatch codebase to use the new public API, but a minimal fix in the meantime would be to adjust
requirements_s3.txt
to uses3path==0.4.2
rather than its currents3path==0.5.0
.The text was updated successfully, but these errors were encountered: