Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App does not report/detect MTP host being blocked by firewall, leaving the user waiting endlessly when downloading #11

Open
MinekPo1 opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@MinekPo1
Copy link

I have an aggressive firewall installed on my android device which blocks most apps from contacting the internet.

While I did whitelist Bunny manager, MTP host was not whitelisted, which was not shown to me, I was waiting with a spinner in front of me.

@Rico040
Copy link

Rico040 commented Jun 12, 2024

What the fuck is MTP

@MinekPo1
Copy link
Author

also didn't know, Media Transfer Protocol (wikipedia, android docs), it seems DownloadManager is handled by the same app as MTP stuff ig, sorry for not including that detail.

Taking a peek into the code, it seems the error is here:

when (status) {
    DownloadManager.STATUS_PENDING, DownloadManager.STATUS_PAUSED ->
        onProgressUpdate(null)

    // [...]
}

You might want to differentiate STATUS_PAUSED from STATUS_PENDING and inform the user that their device might be preventing the download to continue. It seems that this can also happen if the user is not connected to the internet (this might be checked somewhere else, but there is probably some timing "attack" with the user loosing connection at the right time), or some not amazingly documented case which triggers "when the download exceeds a size limit for downloads over the mobile network" (does this apply in this case? I don't know)

tbh not high priority as most likely will only happen to users with a aggressive firewall who presumably would be able to figure out something is off

@amsyarasyiq amsyarasyiq added the bug Something isn't working label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants