-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning out experimental #1794
Comments
Hi @peterg1t, Your experimental graticule alignment code is also being caught up in this. See my message to Jake above. More than happy for the code to come back, but it will need some work from you to get it back in. Cheers, |
Hi @ayalalazaro, Your code has also managed to get caught up in this. You were using some deprecated and now removed numpy APIs. As such, the code is removed for now. More than happy for it to come back in, but these issues would need to be fixed. Cheers, |
Hi @SimonBiggs, I will check it out and see if I can fix it. Thanks! |
Hi @ayalalazaro, I'll make a PR for you that pulls your code back in, that way it should be much easier for you to fix. Let me do that for you and I'll post that soon. |
Hi @rembishj,
Just a heads up, I am doing a bit of a clean out of experimental. If there are any components in experimental that are carrying around a heavy dependency that nothing else within PyMedPhys is using, I am erring on the side of removing the experimental module.
More than happy for it to come back, but just removing it for now until such a time as you have a chance to put some more work into it.
Hope you're doing well :)
Cheers,
Simon
The text was updated successfully, but these errors were encountered: