Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency issues when installing pymedphys[dicom] or pymedphys[user] for use in onkodicom #1772

Open
sjswerdloff opened this issue Nov 11, 2022 · 2 comments

Comments

@sjswerdloff
Copy link
Collaborator

This may not be a pymedphys issue, but:
didymo/OnkoDICOM#248 (comment)

MacOS 12.5.1 (Monterey) on Apple Silicon (Arm64)...
The installation of OnkoDICOM is a bit unusual, in that one uses
poetry to configure a virtual environment (but not jump in to it immediately) then
poetry install
and then
poetry shell
(which starts up the virtual environment).
And then most of the dependencies are no longer available, and one can't repeat poetry install (that fails).
So I iterated through installing packages using pip (try to run OnkoDICOM, have it fail on a dependency, rinse/repeat)
I installed pymedphys (pip install pymedphys) and got 0.39.3
And then a lot of pymedphys dependencies got called out (mostly from _vendor/apipkg). Many of which were not part of anything but requirements-all.txt
Trying to invoke pip on requirements-all.txt failed as well.

I'm wondering if something went wrong with the pymedphys "lazy loading" approach.
Or if something in OnkoDICOM is recursing through all possible dependencies, including those that it doesn't really need.

@SimonBiggs
Copy link
Member

That is interesting. It might be something that a quick video call might be able to get to the bottom of quite quickly? If you'd like to give that a shot, let me know, and we can book in something?

@sjswerdloff
Copy link
Collaborator Author

That is interesting. It might be something that a quick video call might be able to get to the bottom of quite quickly? If you'd like to give that a shot, let me know, and we can book in something?

I'm going to dig in a bit more. I managed to work around the issue with a try/except on the import in OnkoDICOM, but that disables the pseudonymisation feature.
I'll create a separate harness that performs the exact same import(s) of pymedphys to separate out potential sources of problems.
So I'll come back to you on this in about a week.
If I haven't figured things out by then, I will definitely appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants