Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark test for open_datatree #9100

Closed
flamingbear opened this issue Jun 12, 2024 · 0 comments · Fixed by #9158
Closed

Add benchmark test for open_datatree #9100

flamingbear opened this issue Jun 12, 2024 · 0 comments · Fixed by #9158
Labels
contrib-good-first-issue topic-DataTree Related to the implementation of a DataTree class topic-performance

Comments

@flamingbear
Copy link
Contributor

What is your issue?

To prevent regressions in the future, we should add a benchmark test for opening a deeply nested data tree.

This is to follow up on #9014 @aladinor's performance improvements.

You can see here how we benchmark opening and loading a single netCDF file

xarray/asv_bench/benchmarks/dataset_io.py

Line 125 in 447e5a3

def time_load_dataset_netcdf4(self):

@flamingbear flamingbear added needs triage Issue that has not been reviewed by xarray team member contrib-good-first-issue topic-DataTree Related to the implementation of a DataTree class and removed needs triage Issue that has not been reviewed by xarray team member labels Jun 12, 2024
@TomNicholas TomNicholas mentioned this issue Jun 12, 2024
Closed
4 tasks
@aladinor aladinor mentioned this issue Jun 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib-good-first-issue topic-DataTree Related to the implementation of a DataTree class topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add open_datatree benchmark aladinor/xarray
2 participants
@flamingbear @TomNicholas