Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy 2.0 support #680

Closed
jakirkham opened this issue May 16, 2024 · 3 comments · Fixed by #681
Closed

NumPy 2.0 support #680

jakirkham opened this issue May 16, 2024 · 3 comments · Fixed by #681
Labels
enhancement Indicates new feature requests

Comments

@jakirkham
Copy link

Is your feature request related to a problem? Please describe.

NumPy 2.0 is coming out soon ( numpy/numpy#24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( numpy/numpy#24300 (comment) )

Describe the solution you'd like

To prepare for NumPy 2.0, it might be worthwhile to start testing Sparse against NumPy 2 in CI

Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share Sparse current support status in issue (with any plans): numpy/numpy#26191

NumPy has put out a migration guide. More details are in the release notes. As Sparse doesn't have C/C++ usage of NumPy, only the Python changes would be relevant

Describe alternatives you've considered

In the short term, Sparse may wish to set an upper bound on NumPy version until testing can happen. Alternatively Sparse could wait for user issues and address as those come up

Maybe there are other options that haven't been considered here

Additional context

As Sparse depends on Numba, would recommend using the Numba 0.60.0rc1 packages for testing. These work with NumPy 2: numba/numba#9544 (comment)

Note: Numba does not yet provide a NumPy 2 style API, which will likely come in 0.61.0 (or later): numba/numba#9540

@jakirkham jakirkham added the enhancement Indicates new feature requests label May 16, 2024
@hameerabbasi hameerabbasi linked a pull request May 17, 2024 that will close this issue
@hameerabbasi hameerabbasi reopened this May 17, 2024
@hameerabbasi
Copy link
Collaborator

Re-opening for missing PyPI release.

@hameerabbasi
Copy link
Collaborator

Release is up on PyPI: https://pypi.org/project/sparse/0.15.2/

@jakirkham
Copy link
Author

Thanks Hameer! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants