Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the applying flow of proposal to 2023 #1110

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Update the applying flow of proposal to 2023 #1110

merged 1 commit into from
Jan 9, 2023

Conversation

josix
Copy link
Collaborator

@josix josix commented Jan 8, 2023

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • New feature

Description

Describe what the change is

  • Remove pre_recorded_policy from event
  • Update correct PERFER_TIME_CHOICES options

@josix josix requested a review from mattwang44 January 8, 2023 18:34
@josix josix linked an issue Jan 8, 2023 that may be closed by this pull request
Update the applying flow of proposal to 2023 #1111
Closed
@josix josix changed the title feat(proposal): remove pre_recorded_policy from event info Update the applying flow of proposal to 2023 Jan 8, 2023
@josix josix requested review from tyuchx and SivanYeh January 9, 2023 02:42
mattwang44
mattwang44 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

  1. .po 裡面有一些 room name 可以直接填上原文
  2. （雖然我們沒有規範，但是比較好的 practice 是）migration files 可以 rename. e.g. 0056_auto_20230108_2145.py -> 0056_update_2023_policies.py

src/locale/zh_Hant/LC_MESSAGES/django.po Outdated
@@ -4669,3 +4889,31 @@ msgstr ""
#: users/views.py:129
msgid "Password reset successful. You can now login."
msgstr "密碼重設成功。您現在即可登入。"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's delete these outdated line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

src/locale/en_US/LC_MESSAGES/django.po Outdated
@@ -4799,3 +5017,33 @@ msgstr ""
#: users/views.py:129
msgid "Password reset successful. You can now login."
msgstr "Password reset successful. You can now login."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@josix josix merged commit 14549ed into master Jan 9, 2023
@mattwang44 mattwang44 deleted the update/2023-cfp branch January 9, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@tyuchx tyuchx Awaiting requested review from tyuchx

@SivanYeh SivanYeh Awaiting requested review from SivanYeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the applying flow of proposal to 2023
2 participants
@josix @mattwang44