Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startsWith and endsWith #147

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Mar 10, 2021

Description of the change

Add startsWith and endsWith functions to Data.String.CodeUnits.

Fixes #127.

I know that there's still a bit of disagreement over whether this should be done or not, but I just opened this PR because it didn't take a lot of time. If it's ultimately decided against, feel free to close this PR.

To do:

  • suggest stripPrefix and stripSuffix
  • don't use FFI functions, instead use stripPrefix and stripSuffix
  • add functions to Data.String.NonEmpty

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@triallax triallax marked this pull request as ready for review April 11, 2021 12:58
@triallax triallax marked this pull request as draft May 10, 2021 18:33
This is because like `stripPrefix` and `stripSuffix`, these functions
are CodeUnit/CodePoint-agnostic. The same was also done for tests.
@triallax triallax marked this pull request as ready for review July 3, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startsWith and endsWith
1 participant