Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: alvistar/wamped Loading
base: master
Choose a base ref
...
head repository: propershark/wamped Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 16, 2017

  1. Use 4096 character buffers for MsgPack serialization.

    Using statically-sized buffers for dynamically-generated content is never the best solution, and we've run into a situation where we are consistently rubbing up against the initial 1024 character buffer size. Bumping it to 4096 for now seems to be sufficient, but a better solution would be to utilize a dynamically sized buffer, possibly via `std::string` so that memory management is handled implicitly.
    faultyserver committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    c89b1e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2017

  1. Revert buffer size increase.

    There are some internals to the usage of the buffer that cause any change to it's size in `MsgPack.h` to result in a segfault. More research is needed to figure out where exactly the buffer gets used and whether its usage can be replaced by `mpack_writer_init_growable` for mostly-automatic memory management.
    faultyserver committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    3ee83a2 View commit details
    Browse the repository at this point in the history
Loading