Filters out duplicate offences for Github formatters #44
Conversation
| @@ -2,6 +2,13 @@ module Pronto | |||
| module Formatter | |||
| class GithubFormatter | |||
| def format(messages, repo) | |||
| messages = messages.each_with_object(Hash.new { |h, k| h[k] = [] }) { |msg, memo| | |||
There was a problem hiding this comment.
Maybe #uniq could be used here?
There was a problem hiding this comment.
I originally used uniq with a block, but I thought that could have been more inefficient than the avoidance check.
I'd be happy to use uniq if you think it's better.
There was a problem hiding this comment.
Just to clarify, you mean a uniq check inside the each_with_object loop, right? Or is there a way to use uniq on messages that could detect duplicate messages per line, but not across all messages?
There was a problem hiding this comment.
@edk what about something like this:
messages.uniq { |message| [message.msg, message.line.new_line] }There was a problem hiding this comment.
ah! I didn't think of that! Let me try it and update the PR 👍
When the same exact message is repeated on the same line, this change removes the duplicates. The test was updated to reflect this changed behavior as well.
47e15fe
to
24f3019
Compare
|
Updated with sweet refactor, courtesy of @mmozuras :) |
|
@edk looks good. Could you also update |
|
Changelog updated. |
|
@edk thanks, 👍 |
Filters out duplicate offences for Github formatters
When the same exact message is repeated on the same line,
this change removes the duplicates. The test was updated
to reflect this changed behavior as well.
Hi @mmozuras! This PR is now in a branch (sorry I didn't read the contributing guidelines before making the first PR against master) and fixes the failing test.