Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit values #62

Closed
michaelachrisco opened this issue Jan 29, 2015 · 3 comments
Closed

Exit values #62

michaelachrisco opened this issue Jan 29, 2015 · 3 comments

Comments

@michaelachrisco
Copy link

rspec, rubocop, and many other tools will run and have an exit code of 1 if anything is "wrong" with your code.

For example:
rubocop:

rubocop spec 
Inspecting 34 files
..................................

34 files inspected, no offenses detected
$ echo $?
0

fail

rubocop spec 
Inspecting 34 files
.........................C........

Offenses:

spec/mailers/batch_mailer_spec.rb:48:5: C: Use 2 (not 3) spaces for indentation.
       is_expected.to deliver_to(user.email)
    ^^^

34 files inspected, 1 offense detected
echo $?
1

This feature will help with integration of other tools into pronto that look at exit codes.
@michaelachrisco
Copy link
Author

Should be as easy as a Kernel.exit(1)

@michaelachrisco michaelachrisco mentioned this issue Jan 30, 2015
Closed
@michaelachrisco michaelachrisco changed the title Fail with a 1 Exit values Jan 30, 2015
@mmozuras
Copy link
Member

@michaelachrisco there's already --exit-code and no --no-exit-code flags that are meant for that. Do they solve your problem?

@michaelachrisco
Copy link
Author

Yes I did not see that. Ill close this then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added exit values.
2 participants
@mmozuras @michaelachrisco