-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github review comment should be "REQUEST_CHANGES" mode #319
Comments
seems legit to me 👍 |
I like the idea of submitting as Request Changes but making it default and only option seems to be pretty arbitrary. |
I agree with @mknapik - "request changes" makes sense as the default and I think that we should be it configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pronto/lib/pronto/github.rb
Line 52 in 899c6f2
Now it is submitted with "COMMENT" mode.
it should be "REQUEST_CHANGES" (and this is also semantic).
Or, the mode should be selectable by user.
thoughts?
see also:
https://octokit.github.io/octokit.rb/Octokit/Client/Reviews.html#create_pull_request_review-instance_method
https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review
The text was updated successfully, but these errors were encountered: