Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass a .pronto.yml config file #226

Closed
jeroenj opened this issue Apr 21, 2017 · 2 comments
Closed

Add an option to pass a .pronto.yml config file #226

jeroenj opened this issue Apr 21, 2017 · 2 comments

Comments

@jeroenj
Copy link
Contributor

jeroenj commented Apr 21, 2017

In our current setup we use a Docker image to run pronto in a container to run the checks in our CI. Since we have a lot (120+ projects) that should be checked we want to centralise as much of the configs as possible. Because it isn't possible to set the path of a .pronto.yml config file (unless I'm overlooking it?) it means the easiest way to use it is to embed it in all our projects.

It looks like the code already is able to support it, but it just needs to get passed to it? (https://github.com/mmozuras/pronto/blob/master/lib/pronto/config_file.rb#L38)

@mmozuras
Copy link
Member

@jeroenj that's correct. It's almost supported, would accept a pull request adding an option to set a path via a flag 🙂.

@jeroenj
Copy link
Contributor Author

jeroenj commented Apr 24, 2017

Yeah, my idea was to contribute it as soon as I've got the time for it. 👍 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants