Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh translation errors in refrence bezierVertex() #6962

Closed
LKL2017 opened this issue Apr 12, 2024 · 9 comments · Fixed by processing/p5.js-website-legacy#1511
Closed

zh translation errors in refrence bezierVertex() #6962

LKL2017 opened this issue Apr 12, 2024 · 9 comments · Fixed by processing/p5.js-website-legacy#1511

Comments

@LKL2017
Copy link

LKL2017 commented Apr 12, 2024

Topic

I found a translation error at the bezierVertex() section of zh language.

screenshot from website:
image

Current description of parameters x4 , y4 is:

x4  数字:第一个锚点的 x 坐标
y4  数字:第二个锚点的 x 坐标

Expected:

x4  数字:锚点的 x 坐标
y4  数字:锚点的 y 坐标

btw, I didnt found the translation file (json?) in repo, can someone tell me how translate works on p5.js official website? 😂

Copy link

welcome bot commented Apr 12, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@wwwld1
Copy link

wwwld1 commented Apr 12, 2024

Hi, I'd like to work on this issue, thank you!
Chinese is my native language, I think that translation is wrong and should be fixed.

@wwwld1
Copy link

wwwld1 commented Apr 13, 2024

Hi @LKL2017 , I think there is a separate repo for p5.js official website, I just took a look at that repo and made a PR to solve this issue.

@Qianqianye
Copy link
Contributor

Thanks for catching it @LKL2017.
@allcontributors please add @LKL2017 for bug

Copy link
Contributor

@Qianqianye

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @LKL2017! 🎉

@Qianqianye
Copy link
Contributor

Thanks for fixing the translation @wwwld1!
@allcontributors please add @wwwld1 for translation

Copy link
Contributor

@Qianqianye

I've put up a pull request to add @thanks! 🎉

We had trouble processing your request. Please try again later.

@Qianqianye
Copy link
Contributor

@allcontributors please add @wwwld1 for translation

Copy link
Contributor

@Qianqianye

I've put up a pull request to add @wwwld1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants