New light and dark neutral scales
#976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87053db The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* rm @ where it does not effect output * reset * fix fgColor-accent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing... new
lightanddarkneutral base scales! 🎉This isn't technically a breaking change and there should be very little visual differences right now, but we'll be releasing this in Primitives v9 since its a new way of approaching neutral base scales.
Changes
Inverted scales
Going forward, our base scales will follow a reverse pattern where
0is the lightest value inlightand the darkest value indark. This makes it easier to maintain and use for functional tokens where in many cases, both light and dark themes will be identical in base value.Two scales to rule them all
Rather than maintaining separate high contrast scales, we now have only two scales that handle low, medium and high contrast. We adjust contrast by moving up and down the scale, like darker background shades or darker text shades for light high contrast.
Contrast ratios and application
Each step of the scale serves a purpose. The first 5 shades are primarily background shades, 6 and 7 are borders, and 8 to 11 are for text.