Remove Filter input as this component is now part of our internal design system
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesliecdubs
approved these changes
Dec 12, 2023
| @@ -544,7 +544,7 @@ If one of the actions is heavily used, pull it out for easier access. Do not pul | |||
|
|
|||
| ### Filtering | |||
|
|
|||
| A [filter input](/components/filter-input) is used to write a query and only show rows that | |||
| A [filter input (internal)](https://ui.githubapp.com/storybook/?path=/docs/recipes-filter--readme) is used to write a query and only show rows that | |||
There was a problem hiding this comment.
Suggested change
| A [filter input (internal)](https://ui.githubapp.com/storybook/?path=/docs/recipes-filter--readme) is used to write a query and only show rows that | |
| A [filter input (GitHub staff only)](https://ui.githubapp.com/storybook/?path=/docs/recipes-filter--readme) is used to write a query and only show rows that |
I believe this is how we typically denote content in primer.style that is inaccessible to non-Hubbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/github/primer/issues/2912