Add verify checks for abnormal difficulty settings #27683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Mar 21, 2024
osu.Game.Tests/Editing/Checks/CheckAbnormalDifficultySettingsTest.cs
Outdated
Show resolved
Hide resolved
osu.Game/Rulesets/Edit/Checks/CheckAbnormalDifficultySettings.cs
Outdated
Show resolved
Hide resolved
I was wrong, taiko uses HP (to calculate miss penalty).
bdach
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a missing check listed at #12091, based on Mapset Verifier. The only change i've made to how the check behave is that 10K+ on mania doesn't trigger a issue (since there are 10K+ ranked beatmaps).