Load editor's verify tab asynchronously

[nolife99]

Type

Performance

Bug description

When opening the verify tab in an editor, there is an uncomfortable freeze as AIMod checks the map synchronously. This problem is worse on longer maps.

Screenshots or videos

https://streamable.com/7kvkeg (Video was too large)
After clicking verify tab, the app hangs for more than 20 seconds. It might be less on others' machines.
Here is the map for testing: https://osu.ppy.sh/s/1729689

Version

2024.625.2

Logs

compressed-logs.zip

[peppy]

Honestly we can make it asynchronous easily but the real overhead comes from laying out the list.

But the map you are testing with is just stupid and broken. So i'm not willing to put any extra effort into this.

Note: 599 concurrent objects

If you have a beatmap which isn't broken that still loads slow then please provide that for testing.

If we ever need to, here's the async part which is simple to do:

diff --git a/osu.Game/Screens/Edit/Verify/IssueList.cs b/osu.Game/Screens/Edit/Verify/IssueList.cs
index de7b760bcd..567fdd03a2 100644
--- a/osu.Game/Screens/Edit/Verify/IssueList.cs
+++ b/osu.Game/Screens/Edit/Verify/IssueList.cs
@@ -5,6 +5,8 @@
 
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
+using JetBrains.Annotations;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
@@ -90,19 +92,34 @@ protected override void LoadComplete()
             Refresh();
         }
 
+        [CanBeNull]
+        private Task refreshOperation;
+
         public void Refresh()
         {
-            var issues = generalVerifier.Run(context);
+            if (refreshOperation?.IsCompleted == false)
+                return;
 
-            if (rulesetVerifier != null)
-                issues = issues.Concat(rulesetVerifier.Run(context));
+            table.Issues.Clear();
 
-            issues = filter(issues);
+            refreshOperation = Task.Run(() =>
+            {
+                IEnumerable<Issue> issues = generalVerifier.Run(context);
 
-            table.Issues.Clear();
-            table.Issues.AddRange(issues
-                                  .OrderBy(issue => issue.Template.Type)
-                                  .ThenBy(issue => issue.Check.Metadata.Category));
+                if (rulesetVerifier != null)
+                    issues = issues.Concat(rulesetVerifier.Run(context));
+
+                issues = filter(issues)
+                         .OrderBy(issue => issue.Template.Type)
+                         .ThenBy(issue => issue.Check.Metadata.Category)
+                         .ToArray();
+
+                Schedule(() =>
+                {
+                    table.Issues.AddRange(issues);
+                    refreshOperation = null;
+                });
+            });
         }
 
         private IEnumerable<Issue> filter(IEnumerable<Issue> issues)