Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlimited dimensions in Iris conversion #43

Open
pp-mo opened this issue Jan 14, 2024 · 0 comments
Open

Fix unlimited dimensions in Iris conversion #43

pp-mo opened this issue Jan 14, 2024 · 0 comments

Comments

@pp-mo
Copy link
Owner

pp-mo commented Jan 14, 2024

We seem to have a problem with ncdata.dataset_like if we try to save with unlimited dimensions.
Example test code (fails) :

@pytest.mark.skip("'from_iris' not yet working with unlimited dimensions.")
def test_kwargs_unlimited():
"""Check iris-save kwargs control : make the time dimension unlimited."""
cube = sample_cube()
kwargs = dict(unlimited_dimensions=["time"])
ncdata = from_iris(cube, **kwargs)
assert ncdata.dimensions["time"].unlimited is True

Not sure why, but this can wait until after v0.1 to fix.

Note on Relevance

It doesn't really matter that unlimited dims aren't set in the ncdata -- they have no meaning outside of a file, so they can just be adjusted before saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant