Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC normalize/2 to conform to OAuth2 normalize/2 #91

Closed
gaiabeatrice opened this issue Aug 13, 2021 · 3 comments · Fixed by #92
Closed

OIDC normalize/2 to conform to OAuth2 normalize/2 #91

gaiabeatrice opened this issue Aug 13, 2021 · 3 comments · Fixed by #92

Comments

@gaiabeatrice
Copy link

gaiabeatrice commented Aug 13, 2021

I realize that the typespec for normalize/2 belonging to the OIDC strategy is different than the one described in the docs, and the OAuth2 one, and it is making my dialyzer fail.

I believe it should be changed to

@callback normalize(Keyword.t(), map()) :: {:ok, map()} | {:ok, map(), map()} | {:error, term()}

to allow claims that don't conform to the OIDC spec

@danschultzer
Copy link
Collaborator

Good catch, thanks! Fixed in #92.

@gaiabeatrice
Copy link
Author

gaiabeatrice commented Aug 13, 2021

@danschultzer can you cut a release for this, so it can fix the dialyzer errors?

@danschultzer
Copy link
Collaborator

New release is out, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants