Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user param handling #86

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix user param handling #86

merged 1 commit into from
Apr 9, 2021

Conversation

danschultzer
Copy link
Collaborator

This resolves #85

@danschultzer danschultzer mentioned this pull request Apr 8, 2021
Closed
jtormey
jtormey approved these changes Apr 9, 2021
View reviewed changes
Copy link

@jtormey jtormey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast response! Just tested these changes locally, everything works as expected 👍

@danschultzer danschultzer merged commit 9fe6b9f into master Apr 9, 2021
@danschultzer danschultzer deleted the apple-user branch April 9, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtormey jtormey jtormey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callback param "user" is not parsed when using Apple strategy with "name" scope
2 participants
@danschultzer @jtormey