-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should OIDC fetch_user, fetch_userinfo, and validate_id_token allow for dynamic OpenID configuration? #72
Comments
Good call! Yeah, I didn't think of Feel free to open PR calling |
Going to publish new release soon so went ahead and update the functions in #73 |
Thanks for your work on this! |
Hi, and thanks for building and maintaining this 馃憢.
In the configuration documentation for OIDC,
:openid_configuration
isn't strictly required since it can be fetched from:openid_configuration_uri
if it isn't defined. Similarly,:openid_configuration_uri
is also optional, since it defaults to/.well-known/openid-configuration
based on:site
.Both
authorize_url/1
andcallback/3
work this way by callingopenid_configuration/1
. However,fetch_user/2
,fetch_userinfo/2
, andvalidate_id_token/2
are usingConfig.fetch/2
to resolve configuration, so they aren't getting it dynamically.Should these work consistently? I'm a bit new to both Elixir and OIDC, so it's quite possible my understanding is off here.
If the intent is to have them all get
:openid_configuration
dynamically, I'm happy to try submitting a PR.Thanks for your time!
The text was updated successfully, but these errors were encountered: