Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LINE Login OpenID Connect Strategy #58

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

wingyplus
Copy link
Contributor

Add default LINE Login OpenID Connect configuration. The openid configuration
dump from /.well-known/openid-configuration plus id_token_signed_response_alg
to make it work on ID Token with alg HS256.

Closes #57

@wingyplus wingyplus changed the title Add LINE OpenID Connect Add LINE Login OpenID Connect Oct 15, 2020
@wingyplus wingyplus changed the title Add LINE Login OpenID Connect Add LINE Login OpenID Connect Strategy Oct 15, 2020
@wingyplus wingyplus force-pushed the line-login branch 2 times, most recently from 4416632 to aefaf55 Compare October 15, 2020 16:30
wingyplus and others added 2 commits October 18, 2020 11:03
Add default LINE Login OpenID Connect configuration. The openid configuration
dump from /.well-known/openid-configuration plus `id_token_signed_response_alg`
to make it work on ID Token with alg HS256.

Closes pow-auth#57
@danschultzer
Copy link
Collaborator

Thanks, this is great! Sorry for the delay, had to refactor the OIDC strategy, as the handling of id_token_signed_response_alg was not correct. That refactor made this strategy much simpler to implement, so thanks a lot for pointing that out 😄

@danschultzer danschultzer mentioned this pull request Oct 18, 2020
@danschultzer danschultzer merged commit 18b6715 into pow-auth:master Oct 18, 2020
@wingyplus
Copy link
Contributor Author

Thank you very much :)

@wingyplus wingyplus deleted the line-login branch October 19, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LINE OAuth Strategy
2 participants