Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#49] Refactor : Revise ProductDetailView #58

Merged
merged 2 commits into from
Jul 31, 2022
Merged

[#49] Refactor : Revise ProductDetailView #58

merged 2 commits into from
Jul 31, 2022

Conversation

gmkim20713
Copy link
Member

πŸ“ PR Summary

ProductDetailView url 및 response μˆ˜μ •

🌲 Working Branch

feature/product-detail

βœ… TODOs

  • URL ν˜•μ‹ 톡일
  • Response μˆ˜μ • (λΈŒλžœλ“œ 정보 μΆ”κ°€)

Related Issues

@gmkim20713 gmkim20713 linked an issue Jul 31, 2022 that may be closed by this pull request
[FEATURE] νŠΉμ • μƒν’ˆ 상세정보 뢈러였기 #13
Closed
1 task
@1sxyzn 1sxyzn self-requested a review July 31, 2022 17:57
1sxyzn
1sxyzn approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@1sxyzn 1sxyzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λΈŒλžœλ“œ μ—†μœΌλ©΄ null, 있으면 정보 λœ¨λŠ” 것 λ‹€ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ πŸ‘

@gmkim20713 gmkim20713 merged commit 7a8e5ad into develop Jul 31, 2022
@gmkim20713 gmkim20713 self-assigned this Aug 1, 2022
@gmkim20713 gmkim20713 added Type: Refactor [이슈 λͺ©μ ] ν”„λ‘œλ•μ…˜ μ½”λ“œ λ¦¬νŒ©ν† λ§ For: API [이슈 λŒ€μƒ] μ™ΈλΆ€ API labels Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1sxyzn 1sxyzn 1sxyzn approved these changes

Assignees

@gmkim20713 gmkim20713

Labels
For: API [이슈 λŒ€μƒ] μ™ΈλΆ€ API Type: Refactor [이슈 λͺ©μ ] ν”„λ‘œλ•μ…˜ μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
2 participants
@gmkim20713 @1sxyzn