Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression (#579): loss of deletion flag #656

Closed
neojski opened this issue Mar 31, 2013 · 1 comment · Fixed by #8107
Closed

Regression (#579): loss of deletion flag #656

neojski opened this issue Mar 31, 2013 · 1 comment · Fixed by #8107
Assignees
@neojski

Comments

@neojski
Copy link
Member

neojski commented Mar 31, 2013

It is possible to loose information that document got deleted. I'll attach a test in a second.
neojski added a commit to neojski/pouchdb that referenced this issue Mar 31, 2013
@neojski
(pouchdb#656) - add test for specific example of deletion
755c981
@neojski neojski mentioned this issue Mar 31, 2013
Closed
@neojski
Copy link
Member Author

neojski commented Mar 31, 2013

Reason: newEdits=false and falsy doc._revisions part in parseDoc - opts forgotten.

@ghost ghost assigned neojski Apr 1, 2013
neojski added a commit to neojski/pouchdb that referenced this issue Apr 1, 2013
@neojski
(pouchdb#656) - fix loosing deletion of document
d6d0f94
neojski added a commit that referenced this issue Apr 1, 2013
@neojski @daleharvey
(#656) - add test for specific example of deletion
29c4742
neojski added a commit that referenced this issue Apr 1, 2013
@neojski @daleharvey
(#656) - fix loosing deletion of document
a0541ed
howonlee pushed a commit to howonlee/pouchdb that referenced this issue Apr 4, 2013
@neojski @howonlee
(pouchdb#656) - add test for specific example of deletion
7fb8018
howonlee pushed a commit to howonlee/pouchdb that referenced this issue Apr 4, 2013
@neojski @howonlee
(pouchdb#656) - fix loosing deletion of document
2b60fb7
@snyk-bot snyk-bot mentioned this issue Jun 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neojski neojski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade levelup from 4.1.0 to 4.4.0 pouchdb/pouchdb
2 participants
@daleharvey @neojski