Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PouchDB.allDbs should return a promise #1381

Closed
neojski opened this issue Feb 11, 2014 · 4 comments
Closed

PouchDB.allDbs should return a promise #1381

neojski opened this issue Feb 11, 2014 · 4 comments

Comments

@neojski
Copy link
Member

neojski commented Feb 11, 2014

The same as #1377

@daleharvey
Copy link
Member

It should, however taking goodfirstpatch off, we are replacing the allDbs implementation so not particularly worried about fixing this beforehand

@neojski
Copy link
Member Author

neojski commented Feb 11, 2014

Why is enableAllDbs false by default? I need to know allDbs for incremental mapreduce (cleanup issues) or I'd have to keep track of created dbs by myself.

@daleharvey
Copy link
Member

The current implementation I wouldnt consider production worthy, having it do fairly complicated things on part of the critical path of opening a database worries me, allDbs starts acting up and opening a database is impossible

I want to take it out, and its replacement isnt supported 100% (implementation in progress in firefox), so I think we need to think about other ways of keeping track (and taking a look at the couch impl)

@daleharvey
Copy link
Member

after a bunch of discussion, allDbs got removed, the current implementation was never going to be enabled by default, and this lets us look at the alternative implementations

https://github.com/daleharvey/pouchdb/pull/1477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants