-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(page) links not serialized properly when one of the params is a date #724
Comments
Any ideas are welcome @zacharygolba . I can make a PR if you approve of the solution. I'm still a bit in doubt whether or not to make the assumption of an ISO8601 date. |
Would need a "back" port to master as well, as I see the implementation has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requesting a resource with a link like
/my-resource?forDate=2017-10-11T00:00:00.000Z&filter[id]=123,124
gives a Date object for the forDate param. Currently the create-query-string function has no knowledge of correctly serializing a date which results in a page link like:/my-resource?&filter[id]=123,124
which is invalid.Can be solved by modifying
create-page-links
to:This does expect the user to use ISO8601 dates.
The text was updated successfully, but these errors were encountered: