Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure is still using port 443 and https naming convention #88

Closed
Vad1mo opened this issue Apr 27, 2020 · 1 comment · Fixed by #103
Closed

Insecure is still using port 443 and https naming convention #88

Vad1mo opened this issue Apr 27, 2020 · 1 comment · Fixed by #103

Comments

@Vad1mo
Copy link
Contributor

Vad1mo commented Apr 27, 2020

#83 introduced insecure.

Unfortunately it is incomplete. For example when using together with Traefik, then Traefik is guessing based on port number 443 and the port (name?) if the service should called plain or over tls.

The setups with HTTP traffic over port 443 confuses Traefik as it assumes by port number & port name that the upstream service is secure which it isn't.

If insecure=true change Ports from 443 to 80 and rename port from https to http.

@travisgroth
Copy link
Contributor

@Vad1mo I've opened up #103 to try to address this. Can you give it a shot and confirm it works as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants