-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P3] validate Ingress parameter combination #197
Labels
enhancement
New feature or request
NeedsMoreData
Waiting for additional user feedback or case studies
Comments
We should have a single source of "validation" truth if possible. Probably a lot of subtleties here.
Can we abstract the validation code we have across several packages (core, console, ingress-controller) into a centralized validation package in core that can be imported by other projects. |
Let's take a first pass for sizing before starting work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
NeedsMoreData
Waiting for additional user feedback or case studies
Is your feature request related to a problem? Please describe.
Not all combinations of parameters are compatible, i.e.
secure_upstream
prefix_rewrite
would only affect routes that havepathType: Prefix
It is relatively easy to make a mistake (i.e. when starting from a template or example),
and may be impossible to debug or figure out what is wrong.
We currently only detect certain obviously invalid parameter combinations, and validate the configuration via Envoy.
Describe the solution you'd like
Describe alternatives you've considered
Explain any additional use-cases
Additional context
The text was updated successfully, but these errors were encountered: