From b960489699284fe9c621feb58fa12a5c2c4c2efd Mon Sep 17 00:00:00 2001 From: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com> Date: Thu, 12 Oct 2023 10:47:49 -0700 Subject: [PATCH] separate linux and darwin steps (#50) Currently the release automation will fail to upload any binaries if any part of the 'fetch envoy' step fails. This is problematic because we currently attempt to fetch darwin binaries from Homebrew, but Homebrew does not build older patch releases of Envoy. As a temporary workaround, split the 'fetch envoy' step into two, and upload to the release right after fetching. This way, even if we cannot fetch the darwin binaries, we should still fetch and upload the linux binaries. --- .github/workflows/release.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index de0fce3..3b48130 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -32,15 +32,18 @@ jobs: eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" brew install oras - - name: fetch envoy + - name: fetch and upload envoy (linux) + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64 - ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64 ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux amd64 ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux arm64 + gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-linux-* --clobber - - name: Upload artifacts to release + - name: fetch and upload envoy (darwin) env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-* --clobber + ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64 + ./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64 + gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-darwin-* --clobber