Adds Rego capabilities page #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
approved these changes
Aug 1, 2024
content/docs/capabilities/rego.mdx
Outdated
|
|
||
| This example pulls session data from the Databroker service using `type.googleapis.com/session.Session` for users and `type.googleapis.com/user.ServiceAccount` for service accounts. | ||
|
|
||
| ::::enterprise |
There was a problem hiding this comment.
I think we don't need a second Enterprise admonition here if there's already one at the top of the page. That would also allow us to avoid nesting a "Note" admonition inside another admonition.
What about moving this information up, before the "Outputs" section heading?
There was a problem hiding this comment.
Agreed. I went ahead and moved this section up, and removed the enterprise admonition wrapper.
backport-actions-token bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* alphabetizes Enterprise capabilities * migrates rego support content to new page * fixes precommit failures * fixes cspell * moves enterprise admonition
ZPain8464
added a commit
that referenced
this pull request
Aug 2, 2024
Adds Rego capabilities page (#1543) * alphabetizes Enterprise capabilities * migrates rego support content to new page * fixes precommit failures * fixes cspell * moves enterprise admonition Co-authored-by: zachary painter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves https://github.com/pomerium/internal/issues/1874